-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, March 31, 2017 4:03 AM
To: Salil Mehta
Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@gmail.com;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm
Subject: Re: [PATCH net 00/19] net: hns: Misc. HNS Bug Fixes & Code
Improvements

From: Salil Mehta <redacted>
Date: Thu, 30 Mar 2017 16:30:47 +0100

quoted

This patch set introduces various HNS bug fixes, optimizations and

code

quoted

improvements.

There is no way you should do such an expensive calculation for every
single transmit packet as you are doing in your select_queue() routine.

That's really crazy.

Just use the networking stack's queue selection scheme, or suggest
ways to improve it.  Don't do private hashing like this in your
driver, please!

Hi David,
I got your point. I will drop this patch from this patch-set for now.

Thanks
Salil