Re: [Outreachy kernel] [PATCH] net: netfilter: remove unused variable
From: Julia Lawall <hidden>
Date: 2017-03-29 14:16:43
Also in:
lkml, lvs-devel, netfilter-devel
On Wed, 29 Mar 2017, Arushi Singhal wrote:
quoted hunk ↗ jump to hunk
This patch uses the following coccinelle script to remove a variable that was simply used to store the return value of a function call before returning it: @@ identifier len,f; @@ -int len; ... when != len when strict -len = +return f(...); -return len; Signed-off-by: Arushi Singhal <redacted> --- net/netfilter/ipvs/ip_vs_ftp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/net/netfilter/ipvs/ip_vs_ftp.c b/net/netfilter/ipvs/ip_vs_ftp.c index d30c327bb578..9e1e682610ef 100644 --- a/net/netfilter/ipvs/ip_vs_ftp.c +++ b/net/netfilter/ipvs/ip_vs_ftp.c@@ -482,11 +482,9 @@ static struct pernet_operations ip_vs_ftp_ops = { static int __init ip_vs_ftp_init(void) { - int rv; - rv = register_pernet_subsys(&ip_vs_ftp_ops); /* rcu_barrier() is called by netns on error */ - return rv; + return register_pernet_subsys(&ip_vs_ftp_ops);
It looks like you end up with an unnecessary blank line at the beginning of the function. julia
} /* -- 2.11.0 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. To post to this group, send email to outreachy-kernel@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170329133848.GA1336%40arushi-HP-Pavilion-Notebook. For more options, visit https://groups.google.com/d/optout.