Re: [PATCH] netvsc: fix dereference before null check errors

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Mon, 27 Mar 2017 00:50:27 +0000

quoted

-----Original Message-----
From: Colin King [mailto:colin.king@canonical.com]
Sent: Saturday, March 25, 2017 10:27 AM
To: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
[off-list ref]; Stephen Hemminger [off-list ref];
devel@linuxdriverproject.org; netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] netvsc: fix dereference before null check errors

From: Colin Ian King <redacted>

ndev is being checked to see if it is a null pointer however before
the null check ndev is being dereferenced; hence there is a potential
null pointer dereference bug that needs fixing. Fix this by only
dereferencing ndev after the null check.

Detected by CoverityScan, CID#1420760, CID#140761 ("Dereference
before null check")

Signed-off-by: Colin Ian King <redacted>

Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>

Applied.