Re: [Outreachy kernel] Re: [PATCH] net: netfilter: Remove multiple assignment.

On Mon, Mar 27, 2017 at 05:48:41PM +0530, Arushi Singhal wrote:

On Mon, Mar 27, 2017 at 5:38 PM, Pablo Neira Ayuso [off-list ref]
wrote:

quoted

On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote:

quoted

This patch removes multiple assignments.
Done using coccinelle.
@@
identifier i1,i2;
constant c;
@@
- i1=i2=c;
+ i1=c;
+ i2=c;

You have to explain why this is bad.

It is against the kernel coding style and we have to avoid multiple
assignments to make the code more readable.
This error is found using Checkpatch.pl script.

Then, please place this information in your patch description.

Thanks!