Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hi Peppe,

Às 10:48 AM de 3/23/2017, Giuseppe CAVALLARO escreveu:

Hello

On 3/23/2017 11:20 AM, Corentin Labbe wrote:

quoted

quoted

I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression.

quoted

Could you please share the iperf cmds you are using in order for me to

reproduce

quoted

in my side?

Joao, you have a really powerful HW integration with multiple channels for both
RX and TX.
Often this is not the same for other setup where, usually just a DMA0 is present
or, sometime, there
is just one RX extra channel.

My opinion is that we should not have problems, since the majority of features
introduced are used if you configure rx queues > 1 or tx queues > 1, so if you
use the default (=1) those confiogurations will not take place.

My question is, what happens on this kind of configurations? Are we still
guarantying the best performances?

Also we have to guarantee, that the TSO and SG are always working. Another point
is the buffer sizes that
can be different among platforms.

We have to pay attention to the RX buffer size, since I had problems with DHCP
messages not being received because of little buffer size.
Currently TX buffer size is not configurable and in the future it should be
useful to include it too.

The problem  below reported by Corentin push me to think that there is a bug, so
we should
understand when this has been introduced and if likely fixed by some
configuration we are
not take care right now.

Of course.

ndesc_get_rx_status: Oversized frame spanned multiple buffers"


Best Regards
Peppe

Thanks,
Joao