Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver
From: Wolfgang Grandegger <hidden>
Date: 2017-03-17 08:18:56
Also in:
linux-can, linux-devicetree, lkml
From: Wolfgang Grandegger <hidden>
Date: 2017-03-17 08:18:56
Also in:
linux-can, linux-devicetree, lkml
Hello Akshay, Am 17.03.2017 um 08:39 schrieb Wolfgang Grandegger:
Hello Akshay, Am 16.03.2017 um 23:29 schrieb Akshay Bhat:quoted
Hi Wolfgang, On 03/16/2017 04:02 PM, Wolfgang Grandegger wrote:quoted
Looks much better now! There are message for state changes to error warning and passive. Just the following message is not correct: (000.200824) can0 20000004 [8] 00 40 00 00 00 00 5F 19 ERRORFRAME controller-problem{} error-counter-tx-rx{{95}{25}} Sorry, forgot to mention... the function can_change_state() [1] should be used for that purpose, if possible. It fixes the issue above as well.The updated driver (the one used to create the above log) is using can_change_state() function. data[1] 40 corresponds to CAN_ERR_CRTL_ACTIVE, so looks correct? Could it be that the can-utils I am using is old and not reporting state change?Hm, yes. The raw data looks correct. You could download and build a recent version from "https://github.com/linux-can/can-utils" to check. It could also be a bug.
Support for that flags has been added in December 2014. Wolfgang-