Thread (13 messages) flat view 13 messages, 3 authors, 2017-03-28

Re: [PATCH 3/4] uapi glibc compat: Do not check for __USE_MISC

From: David Woodhouse <dwmw2@infradead.org>
Date: 2017-03-16 07:59:37
Also in: lkml

On Sun, 2017-03-12 at 23:00 +0100, Hauke Mehrtens wrote:
__USE_MISC is glibc specific and not available in musl libc. Only do
this check when glibc is used. This fixes a problem with musl libc.
...
-/* Coordinate with glibc net/if.h header. */
-#if defined(_NET_IF_H) && defined(__USE_MISC)
+/* Coordinate with libc net/if.h header. */
+#if defined(_NET_IF_H) && (!defined(__GLIBC__) || defined(__USE_MISC))
I *really* don't like building up a plethora of knowledge about
specific libc implementations in the kernel. As a general rule, if we
have *anything* that depends on __GLIBC__ then we are Doing It Wrong™.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help