Thread (3 messages) flat view 3 messages, 2 authors, 2017-03-14

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

From: Guenter Roeck <linux@roeck-us.net>
Date: 2017-03-14 02:13:19
Also in: lkml

On 03/13/2017 03:32 PM, David Miller wrote:
From: Guenter Roeck <linux@roeck-us.net>
Date: Fri, 10 Mar 2017 17:45:21 -0800
quoted
An insert/remove stress test generated the following log message sequence.
...
quoted
Use netdev_dbg() instead of netdev_warn() for the repeating messages
to reduce logging noise.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
The problem I have with changes like this is that outside of your
stress test situation these messages are extremely useful but will
now be hidden making diagnosis of problems more difficult.
In general I agree, but in this case the calling code also generates
another set of error messages, which I considered a bit excessive.

No problem, though, we can live with the noise.

Guenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help