Thread (2 messages) flat view 2 messages, 2 authors, 2017-03-06

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

From: Kalle Valo <hidden>
Date: 2017-03-06 16:29:59
Also in: linux-media, linux-wireless, lkml

Arend Van Spriel [off-list ref] writes:
On 2-3-2017 17:38, Arnd Bergmann wrote:
quoted
With KASAN and a couple of other patches applied, this driver is one
of the few remaining ones that actually use more than 2048 bytes of
kernel stack:

broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_gainctrl':
broadcom/brcm80211/brcmsmac/phy/phy_n.c:16065:1: warning: the frame size of 3264 bytes is larger than 2048 bytes [-Wframe-larger-than=]
broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy':
broadcom/brcm80211/brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=]

Here, I'm reducing the stack size by marking as many local variables as
'static const' as I can without changing the actual code.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Arnd, via which tree are you planning to submit these? I'm not sure
what I should do with the wireless drivers patches from this series.

-- 
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help