Re: [PATCH 24/26] ocfs2: reduce stack size with KASAN

From
Arnd Bergmann <arnd@arndb.de>
Date
2017-03-02 23:02:31
Also in
linux-media, linux-wireless, lkml
Reply to
Joe Perches, 2017-03-02
On Thu, Mar 2, 2017 at 11:40 PM, Joe Perches [off-list ref] wrote:
On Thu, 2017-03-02 at 23:22 +0100, Arnd Bergmann wrote:
quoted
On Thu, Mar 2, 2017 at 6:46 PM, Joe Perches [off-list ref] wrote:
quoted
On Thu, 2017-03-02 at 17:38 +0100, Arnd Bergmann wrote:
quoted
The internal logging infrastructure in ocfs2 causes special warning code to be
used with KASAN, which produces rather large stack frames:
fs/ocfs2/super.c: In function 'ocfs2_fill_super':
fs/ocfs2/super.c:1219:1: error: the frame size of 3264 bytes is larger than 3072 bytes [-Werror=frame-larger-than=]
At least by default it doesn't seem to.

gcc 6.2 allyesconfig, CONFIG_KASAN=y
with either CONFIG_KASAN_INLINE or CONFIG_KASAN_OUTLINE

gcc doesn't emit a stack warning
The warning is disabled until patch 26/26. which picks the 3072 default.
The 3264 number was with gcc-7, which is worse than gcc-6 since it enables
an extra check.
quoted
quoted
By simply passing the mask by value instead of reference, we can avoid the
problem completely.
Any idea why that's so?
With KASAN, every time we inline the function, the compiler has to allocate
space for another copy of the variable plus a redzone to detect whether
passing it by reference into another function causes an overflow at runtime.
These logging functions aren't inlined.
Sorry, my mistake. In this case mlog() is a macro, not an inline functions.
The effect is the same though.
You're referring to the stack frame?
The stack frame of the function that calls mlog(), yes.
Still doesn't make sense to me.

None of the logging functions are inlined as they are all
EXPORT_SYMBOL.
mlog() is placed in the calling function.
This just changes a pointer to a u64, which is the same
size on x86-64 (and is of course larger on x86-32).
KASAN decides that passing a pointer to _m into an extern function
(_mlog_printk) is potentially dangerous, as that function might
keep a reference to that pointer after it goes out of scope,
or it might not know the correct length of the stack object pointed to.

We can see from looking at the __mlog_printk() function definition
that it's actually safe, but the compiler cannot see that when looking
at another source file.
Perhaps KASAN has the odd behavior and working around
KASAN's behavior may not be the proper thing to do.
Turning off KASAN fixes the problem, but the entire purpose of
KASAN is to identify code that is potentially dangerous.
Maybe if CONFIG_KASAN is set, the minimum stack should
be increased via THREAD_SIZE_ORDER or some such.
This is what happened in 3f181b4d8652 ("lib/Kconfig.debug:
disable -Wframe-larger-than warnings with KASAN=y").

I'm trying to revert that patch so we actually get warnings
again about functions that are still dangerous. I picked 3072
as an arbitrary limit, as there are only a handful of files
that use larger stack frames in the worst case, but we can
only use that limit after fixing up all the warnings it shows.

       Arnd
Thread (62 messages) 62 messages, 8 authors, last reply 2017-03-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help