Thread (8 messages) flat view 8 messages, 3 authors, 2017-03-30

Re: [PATCH net v2 1/3] net/packet: fix overflow in check for priv area size

From: Eric Dumazet <hidden>
Date: 2017-03-29 15:50:57

On Wed, 2017-03-29 at 16:11 +0200, Andrey Konovalov wrote:
Subtracting tp_sizeof_priv from tp_block_size and casting to int
to check whether one is less then the other doesn't always work
(both of them are unsigned ints).

Compare them as is instead.

Also cast tp_sizeof_priv to u64 before using BLK_PLUS_PRIV, as
it can overflow inside BLK_PLUS_PRIV otherwise.

Signed-off-by: Andrey Konovalov <redacted>
---
Acked-by: Eric Dumazet <edumazet@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help