Re: [PATCH net-next] rtnl: Add support for netdev event to link messages
From: David Miller <davem@davemloft.net>
Date: 2017-03-27 22:59:29
From: Vladislav Yasevich <redacted> Date: Sat, 25 Mar 2017 21:59:47 -0400
RTNL currently generates notifications on some netdev notifier events. However, user space has no idea what changed. All it sees is the data and has to infer what has changed. For some events that is not possible. This patch adds a new field to RTM_NEWLINK message called IFLA_EVENT that would have an encoding of the which event triggered this notification. Currectly, only 2 events (NETDEV_NOTIFY_PEERS and NETDEV_MTUCHANGED) are supported. These events could be interesting in the virt space to trigger additional configuration commands to VMs. Other events of interest may be added later. Signed-off-by: Vladislav Yasevich <redacted>
At what point do we start providing the metadata for the changed values as well? You'd probably need to provide both the old and new values to cover all cases.
quoted hunk ↗ jump to hunk
@@ -4044,6 +4076,7 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb) return skb->len; } + /* Process one rtnetlink message. */ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
Please don't add more empty lines between functions, one is enough.