Re: [PATCH net] ping: implement proper locking

On Fri, Mar 24, 2017 at 04:29:45PM -0700, Eric Dumazet wrote:

From: Eric Dumazet <edumazet@google.com>

We got a report of yet another bug in ping

http://www.openwall.com/lists/oss-security/2017/03/24/6

->disconnect() is not called with socket lock held.

Fix this by acquiring ping rwlock earlier.

Thanks to Alexander and Andrey for letting us know of this problem.

Fixes: c319b4d76b9e ("net: ipv4: add IPPROTO_ICMP socket kind")
Reported-by: Solar Designer <redacted>
Reported-by: Andrey Konovalov <redacted>

We should credit the original reporter, who most likely found this by
fuzzing.  It's danieljiang0415 on GitHub and Twitter.  Unfortunately, I
don't know their e-mail address.  I'll try asking.

Alexander