Thread (21 messages) flat view 21 messages, 6 authors, 2017-03-27

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

From: Joao Pinto <hidden>
Date: 2017-03-24 17:19:22

Às 5:17 PM de 3/24/2017, David Miller escreveu:
From: Joao Pinto <redacted>
Date: Fri, 24 Mar 2017 15:02:27 +0000
quoted
Yes, I agree, it is better to revert and leave the tree functional for all.

@David Miller:
The multiple-buffer patch introduced some problems in some setups that are being
hard to debug, so Corentin gave the idea of reverting the until
commit 7bac4e1ec3ca2342929a39638d615c6b672c27a0 (net: stmmac: stmmac interrupt
treatment prepared for multiple queues), which I fully agree.

In my setup is ok, but the idea is to have everyone's setup working :), so lets
break them into smaller pieces, and let's only apply them when everyone confirms
that is working ok in your setups, agree?

What is the typical mechanism for this? I send a patch reverting them?
If you can compose a single "git revert" command to achieve this, just
tell me what it is and I'll do it.

Otherwise send a patch that does the revert.
Ok, I sent 2 patches with fixes. Let's see if you get some happy clients.
If not, I will inform the commit id to revert.

Thanks David.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help