Re: [PATCH nf v3 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register

On Fri, Mar 24, 2017 at 01:21:30PM +0100, Pablo Neira Ayuso wrote:

On Tue, Mar 21, 2017 at 08:22:29AM +0800, fgao@ikuai8.com wrote:

quoted

From: Gao Feng <redacted>

In the commit 93557f53e1fb ("netfilter: nf_conntrack: nf_conntrack snmp
helper"), the snmp_helper is replaced by nf_nat_snmp_hook. So the
snmp_helper is never registered. But it still tries to unregister the
snmp_helper, it could cause the panic.

This patch looks correct to me.

But probably for some reason I don't manage to trigger, how do you
reproduce this?

I'm refering to the panic.