Hi Harald,
On 03/15/2017 05:39 PM, Harald Welte wrote:
Hi Jonas,
are you working on the review feedback that was provided back in early
February? I think there were some comments like
* remove unrelated cosmetic change in comment
* change from FLAGS to a dedicated MODE netlink attribute
* add libgtpnl code and some usage information or even sample scripts
I would definitely like to see this move forward, particularly in order
to test the GGSN-side code.
Sorry for the delay in this.
I've sent, just now, revised patches to the kernel module.
I was going to send some libgtpnl patches but I noticed, when gathering these up, that you have already made most of the necessary changes on a new branch. What you've got there is almost identical to what I've got.
Since you used the terminology "role" instead of "mode" in your libgtpnl branch, I made the corresponding change in the kernel module, too, so it now calls this role instead of mode.
Regards,
Jonas
Regards,
Harald