Re: [PATCH net v2 1/1] net: tcp: Permit user set TCP_MAXSEG to default value
From: Neal Cardwell <ncardwell@google.com>
Date: 2017-03-21 01:23:46
On Mon, Mar 20, 2017 at 8:45 PM, [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 1e319a5..4f7f163 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c@@ -2470,7 +2470,7 @@ static int do_tcp_setsockopt(struct sock *sk, int level, /* Values greater than interface MTU won't take effect. However * at the point when this call is done we typically don't yet * know which interface is going to be used */ - if (val < TCP_MIN_MSS || val > MAX_TCP_WINDOW) { + if (!val && (val < TCP_MIN_MSS || val > MAX_TCP_WINDOW)) { err = -EINVAL; break;
I believe the sense of the val check is flipped in the proposed patch.
I believe Eric suggested:
if (val && (val < TCP_MIN_MSS || val > MAX_TCP_WINDOW)) {
Has this been tested?
neal