Thread (2 messages) read the whole thread 2 messages, 2 authors, 2017-03-17

Re: [PATCH net] tcp: tcp_get_info() should read tcp_time_stamp later

From: David Miller <davem@davemloft.net>
Date: 2017-03-17 04:37:41

From: Eric Dumazet <redacted>
Date: Thu, 16 Mar 2017 15:43:19 -0700
From: Eric Dumazet <edumazet@google.com>

Commit b369e7fd41f7 ("tcp: make TCP_INFO more consistent") moved
lock_sock_fast() earlier in tcp_get_info()

This has the minor effect that jiffies value being sampled at the
beginning of tcp_get_info() is more likely to be off by one, and we
report big tcpi_last_data_sent values (like 0xFFFFFFFF).

Since we lock the socket, fetching tcp_time_stamp right before
doing the jiffies_to_msecs() calls is enough to remove these
wrong values.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help