Thread (4 messages) flat view 4 messages, 2 authors, 2017-03-13

[PATCHv3 2/4] rds: ib: remove redundant ib_dealloc_fmr

From: Zhu Yanjun <hidden>
Date: 2017-03-13 05:44:09
Also in: linux-rdma
Subsystem: networking [general], rds - reliable datagram sockets, the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Allison Henderson, Linus Torvalds

The function ib_dealloc_fmr will never be called. As such, it should
be removed.

Cc: Joe Jin <redacted>
Cc: Junxiao Bi <redacted>
Reviewed-by: Yuval Shaia <redacted>
Reviewed-by: Johannes Thumshirn <redacted>
Acked-by: Santosh Shilimkar <redacted>
Signed-off-by: Zhu Yanjun <redacted>
---
 net/rds/ib_fmr.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/rds/ib_fmr.c b/net/rds/ib_fmr.c
index 4fe8f4f..249ae1c 100644
--- a/net/rds/ib_fmr.c
+++ b/net/rds/ib_fmr.c
@@ -78,12 +78,9 @@ struct rds_ib_mr *rds_ib_alloc_fmr(struct rds_ib_device *rds_ibdev, int npages)
 	return ibmr;
 
 out_no_cigar:
-	if (ibmr) {
-		if (fmr->fmr)
-			ib_dealloc_fmr(fmr->fmr);
-		kfree(ibmr);
-	}
+	kfree(ibmr);
 	atomic_dec(&pool->item_count);
+
 	return ERR_PTR(err);
 }
 
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help