[PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject
From: Zhu Yanjun <hidden>
Date: 2017-03-13 05:43:45
Also in:
linux-rdma
Subsystem:
networking [general], rds - reliable datagram sockets, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Allison Henderson, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-03-13 · Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject · Leon Romanovsky <hidden>
- 2017-03-13 · Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject · Yanjun Zhu <hidden>
- 2017-03-13 · Re: [PATCHv3 1/4] rds: ib: drop unnecessary rdma_reject · Leon Romanovsky <hidden>
When rdma_accept fails, rdma_reject is called in it. As such, it is not necessary to execute rdma_reject again. Cc: Joe Jin <redacted> Cc: Junxiao Bi <redacted> Acked-by: Santosh Shilimkar <redacted> Signed-off-by: Zhu Yanjun <redacted> --- net/rds/ib_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index ce3775a..4b9405c 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c@@ -677,9 +677,8 @@ int rds_ib_cm_handle_connect(struct rdma_cm_id *cm_id, event->param.conn.initiator_depth); /* rdma_accept() calls rdma_reject() internally if it fails */ - err = rdma_accept(cm_id, &conn_param); - if (err) - rds_ib_conn_error(conn, "rdma_accept failed (%d)\n", err); + if (rdma_accept(cm_id, &conn_param)) + rds_ib_conn_error(conn, "rdma_accept failed\n"); out: if (conn)
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html