Re: [PATCH iproute2 master] bpf: test for valid type in bpf_get_work_dir
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-03-09 02:06:43
On Mon, 6 Mar 2017 13:06:00 +0100 Daniel Borkmann [off-list ref] wrote:
Jan-Erik reported an assertion in bpf_prog_to_subdir() failed where
type was BPF_PROG_TYPE_UNSPEC, which is only used in bpf_init_env()
to auto-mount and cache the bpf fs mount point.
Therefore, make sure when bpf_init_env() is called multiple times
(f.e. eBPF classifier with eBPF action attached) and bpf_mnt_cached
is set already that the type is also valid. In bpf_init_env(), we're
only interested in the mount point and not a type-specific subdir.
Fixes: e42256699cac ("bpf: make tc's bpf loader generic and move into lib")
Reported-by: Jan-Erik Rediger <redacted>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>Applied