Thread (18 messages) flat view 18 messages, 6 authors, 2017-03-07

Re: [PATCH net] dccp: fix use-after-free in dccp_feat_activate_values

From: David Miller <davem@davemloft.net>
Date: 2017-03-07 22:41:07

From: Eric Dumazet <redacted>
Date: Sun, 05 Mar 2017 10:52:16 -0800
From: Eric Dumazet <edumazet@google.com>

Dmitry reported crashes in DCCP stack [1]

Problem here is that when I got rid of listener spinlock, I missed the
fact that DCCP stores a complex state in struct dccp_request_sock,
while TCP does not.

Since multiple cpus could access it at the same time, we need to add
protection.
 ...
Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Tested-by: Dmitry Vyukov <dvyukov@google.com>
Applied and queued up for -stable.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help