Re: [PATCH net-next 1/1] net: rmnet_data: Initial implementation

From: Subash Abhinov Kasiviswanathan <redacted>
Date: Thu, 23 Feb 2017 20:30:54 -0700

+struct rmnet_nl_msg_s {
+	uint16_t reserved;
+	uint16_t message_type;
+	uint16_t reserved2:14;
+	uint16_t crd:2;

Inside the kernel you should use "u32", "u16", "u8", etc. for purely
internal things, and for datastructures exported to userspace you
should use "__u32", "__u16", "__u8".

Furthermore, if the members have specific endianness you should
properly use the "__le32", "__le16", "__be32", "__be16" etc. types.

+/**
+ * rmnet_vnd_ioctl() - IOCTL NDO callback

Please use netlink for device instantiation and configuration
rather than ioctls.