Re: [PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

On Thu, Feb 16, 2017 at 3:06 AM, Raju Lakkaraju
[off-list ref] wrote:

Hi Rob,

On Wed, Feb 15, 2017 at 10:45:40AM -0600, Rob Herring wrote:

quoted

EXTERNAL EMAIL


On Tue, Feb 07, 2017 at 07:10:26PM +0530, Raju Lakkaraju wrote:

quoted

From: Raju Lakkaraju <Raju.Lakkaraju-dzo6w/eZyo2tG0bUXCXiUA@public.gmane.org>

+                       Default value is VSC8531_LINK_1000_ACTIVITY (1).
+- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave.

You failed to address my comment on v2. vsc8531 is not a vendor prefix.
Please fix in a new patch since David already applied it.

Accpeted my fault. i missed your comment.
Do i need to change from  "vsc8531, led-0-mode" to "mscc, led-0-mode"
Is this your suggestion?

Well, there shouldn't be a space there, but yess, mscc is the prefix.

Read my original comments. I also suggested combining this to a single property.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html