Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support
From: Thomas Petazzoni <hidden>
Date: 2017-02-02 16:44:57
Also in:
linux-arm-kernel, linux-devicetree
Possibly related (same subject, not in this thread)
- 2017-02-21 · Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support · Thomas Petazzoni <hidden>
- 2017-02-14 · Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support · Thomas Petazzoni <hidden>
- 2017-02-03 · Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support · Russell King - ARM Linux <linux@armlinux.org.uk>
- 2017-02-02 · Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support · Thomas Petazzoni <hidden>
- 2017-01-03 · Re: [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support · Rob Herring <hidden>
Hello, On Sat, 7 Jan 2017 09:32:28 +0000, Russell King - ARM Linux wrote:
On Wed, Dec 28, 2016 at 05:46:17PM +0100, Thomas Petazzoni wrote:quoted
@@ -31,7 +43,7 @@ Optional properties (port): then fixed link is assumed, and the 'fixed-link' property is mandatory.Not directly related to this patch, but this context is wrong. The PP2 driver _requires_ a PHY. It doesn't support fixed-link in its current form. I think the DT binding describes an expectation of a future driver. The side effect is that if trying to use a fixed-link on any port, the ethernet driver fails to probe.
Correct. I will send a patch to adjust the Device Tree binding documentation accordingly. Thanks for noticing this mistake! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com