Re: [PATCH net-next V2] virito-net: set queues after reset during xdp_set
From: David Miller <davem@davemloft.net>
Date: 2017-02-21 03:23:13
Also in:
lkml, virtualization
From: David Miller <davem@davemloft.net>
Date: 2017-02-21 03:23:13
Also in:
lkml, virtualization
From: Jason Wang <jasowang@redhat.com> Date: Mon, 20 Feb 2017 11:50:20 +0800
We set queues before reset which will cause a crash[1]. This is because is_xdp_raw_buffer_queue() depends on the old xdp queue pairs number to do the correct detection. So fix this by - passing xdp queue pairs and current queue pairs to virtnet_reset() - change vi->xdp_qp after reset but before refill, to make sure both free_unused_bufs() and refill can make correct detection of XDP. - remove the duplicated queue pairs setting before virtnet_reset() since we will do it inside virtnet_reset() [1]
...
Fixes: 2de2f7f40ef9 ("virtio_net: XDP support for adjust_head")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>Applied and queued up for -stable, thanks Jason.