Re: [PATCH net-next v4 04/11] bpf: Use bpf_load_program() from the library
From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2017-02-09 21:28:58
Also in:
lkml
On 02/08/2017 09:49 PM, Mickaël Salaün wrote:
Replace bpf_prog_load() with bpf_load_program() calls. Signed-off-by: Mickaël Salaün <mic@digikod.net> Cc: Alexei Starovoitov <redacted> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Shuah Khan <shuah@kernel.org>
[...]
quoted hunk ↗ jump to hunk
diff --git a/tools/testing/selftests/bpf/test_tag.c b/tools/testing/selftests/bpf/test_tag.c index 5f7c602f47d1..b77dc4b03e77 100644 --- a/tools/testing/selftests/bpf/test_tag.c +++ b/tools/testing/selftests/bpf/test_tag.c@@ -16,6 +16,8 @@ #include <linux/bpf.h> #include <linux/if_alg.h> +#include <bpf/bpf.h> + #include "../../../include/linux/filter.h" #include "bpf_sys.h"@@ -55,8 +57,8 @@ static int bpf_try_load_prog(int insns, int fd_map, int fd_prog; bpf_filler(insns, fd_map); - fd_prog = bpf_prog_load(BPF_PROG_TYPE_SCHED_CLS, prog, insns * - sizeof(struct bpf_insn), "", NULL, 0); + fd_prog = bpf_load_program(BPF_PROG_TYPE_SCHED_CLS, prog, insns, "", 0, + NULL, 0);
Went over the set and generally looks good. Please make sure though,
like in above case that you properly fix aligning next line to the
opening '('. I've noticed this multiple times in this and in the next
patch at least. Please double check the rest of your series as well.
Thanks,
Daniel