RE: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by other virtual intefaces

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Tuesday, February 07, 2017 10:28 AM
To: Grandhi, Sainath <redacted>
Cc: <redacted>; <redacted>; linux-
kernel@vger.kernel.org
Subject: Re: [PATCHv4 0/7] Refactor macvtap to re-use tap functionality by
other virtual intefaces

From: Sainath Grandhi <redacted>
Date: Mon,  6 Feb 2017 13:36:08 -0800

quoted

Tap character devices can be implemented on other virtual interfaces
like ipvlan, similar to macvtap. Source code for tap functionality in
macvtap can be re-used for this purpose.

This patch series splits macvtap source into two modules, macvtap and tap.
This patch series also includes a patch for implementing tap character
device driver based on the IP-VLAN network interface, called ipvtap.

These patches are tested on x86 platform.

You're going to have to rework the module and Kconfig parts of this set of
changes.

The user should not have to modify any existing Kconfig setting to get the
same set of modules which already exist today.

Yet when I run "make oldconfig" after applying these changes it prompts me
for:

    TAP module support for virtual interfaces (TAP) [N/m/y/?] (NEW)

And that's not really acceptable.  I had MACVTAP set, I should still get the
infrastructure necessary to get that module built.

If you want to do patch #6 you have to do it in a way that is transparent to
existing kernel configs.

Please check the next version of patches. Modified Kconfig to make TAP as an user non-visible symbol.

Thanks.