Re: [RFC 19/19] checkpatch: warn for use of old PCI pool API
From: Peter Senna Tschudin <hidden>
Date: 2017-02-08 19:00:18
Also in:
linux-rdma, linux-scsi, lkml
On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
pci_pool_*() functions should be replaced by the corresponding functions in the DMA pool API. This adds support to check for use of these pci functions and display a warning when it is the case.
Don't know if relevant, but did not catch the struct. Other than that works fine.
quoted hunk
Signed-off-by: Romain Perier <redacted> --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 8e96af5..026920e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl@@ -6058,6 +6058,11 @@ sub process { WARN("USE_DEVICE_INITCALL", "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr); } +# check for old PCI api pci_pool_*(), use dma_pool_*() instead + if ($line =~ /\bpci_pool_.+\(/) { + WARN("USE_PCI_POOL", + "please use the dma pool api or more appropriate function instead of the old pci pool api\n" . $herecurr); + } # check for various structs that are normally const (ops, kgdb, device_tree) if ($line !~ /\bconst\b/ &&-- 2.9.3