Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set
From: Nikolay Aleksandrov <hidden>
Date: 2017-02-07 11:30:22
Also in:
bridge, kernel-janitors, lkml
From: Nikolay Aleksandrov <hidden>
Date: 2017-02-07 11:30:22
Also in:
bridge, kernel-janitors, lkml
On 07/02/17 11:56, Colin King wrote:
From: Colin Ian King <redacted> The error check on err is redundant as it is being checked previously each time it has been updated. Remove this redundant check. Detected with CoverityScan, CID#140030("Logically dead code") Signed-off-by: Colin Ian King <redacted> --- net/bridge/br_netlink.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index fc5d885..cdc4e2a 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c@@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br, return err; break; } - - if (err) - return err; } return err;
Actually that code can be reduced further, I'll follow up with a patch later. Reviewed-by: Nikolay Aleksandrov <redacted>