[PATCH] net: phy: dp83867: Fall-back to default values of clock delay and FIFO depth
From: Alexey Brodkin <hidden>
Date: 2017-02-06 19:24:56
Also in:
lkml
Subsystem:
ethernet phy library, networking drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Given there're default values mentioned in the PHY datasheet fall-back gracefully to them instead of silently return an error through the whole call-chain. This allows to use minimalistic description in DT if no special features are required. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Murali Karicheri <redacted> Cc: Sekhar Nori <redacted> Cc: David S. Miller <davem@davemloft.net> Cc: Grygorii Strashko <grygorii.strashko@ti.com> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Mugunthan V N <redacted> Cc: Andrew Lunn <andrew@lunn.ch> --- drivers/net/phy/dp83867.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index ca1b462..5d8c5ec 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c@@ -135,17 +135,20 @@ static int dp83867_of_init(struct phy_device *phydev) if (ret && (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)) - return ret; + dp83867->rx_id_delay = DP83867_RGMIIDCTL_2_00_NS; ret = of_property_read_u32(of_node, "ti,tx-internal-delay", &dp83867->tx_id_delay); if (ret && (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)) - return ret; + dp83867->tx_id_delay = DP83867_RGMIIDCTL_2_00_NS; - return of_property_read_u32(of_node, "ti,fifo-depth", - &dp83867->fifo_depth); + ret = of_property_read_u32(of_node, "ti,fifo-depth", &dp83867->fifo_depth); + if (ret) + dp83867->fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB; + + return 0; } #else static int dp83867_of_init(struct phy_device *phydev)
--
2.10.2