RE: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
From: Yotam Gigi <hidden>
Date: 2017-02-06 16:41:37
Also in:
lkml
-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
Behalf Of Arnd Bergmann
Sent: Monday, February 06, 2017 6:27 PM
To: Jiri Pirko <redacted>; Ido Schimmel <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>;
Vadim Pasternak [off-list ref]; Elad Raz [off-list ref]; Ivan
Vecera [off-list ref]; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] [net-next] mlxsw: add psample dependency for spectrum
When PSAMPLE is a loadable module, spectrum must not be built-in:
drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func':
spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet'
This adds a Kconfig dependency to enforce usable configurations.
Fixes: 98d0f7b9acda ("mlxsw: spectrum: Add packet sample offloading support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Acked-by: Yotam Gigi <redacted>
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfigb/drivers/net/ethernet/mellanox/mlxsw/Kconfig index 76a7574c3c7d..ef23eaedc2ff 100644--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig@@ -73,6 +73,7 @@ config MLXSW_SWITCHX2config MLXSW_SPECTRUM tristate "Mellanox Technologies Spectrum support" depends on MLXSW_CORE && MLXSW_PCI && NET_SWITCHDEV && VLAN_8021Q + depends on PSAMPLE || PSAMPLE=n select PARMAN default m ---help--- -- 2.9.0