Thread (12 messages) flat view 12 messages, 4 authors, 2017-02-03

Re: [PATCH 2/2] net: ethernet: bgmac: mac address change bug

From: Jon Mason <hidden>
Date: 2017-02-02 18:13:29
Also in: lkml

On Wed, Feb 1, 2017 at 6:12 PM, Rafał Miłecki [off-list ref] wrote:
On 02/01/2017 11:39 PM, Jon Mason wrote:
quoted
From: Hari Vyas <redacted>

ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to
bgmac_set_mac_address() but code assumed u8 *.  This caused two bytes
chopping and the wrong mac address was configured.

Signed-off-by: Hari Vyas <redacted>
Signed-off-by: Jon Mason <redacted>
Fixes: 4e209001b86 ("bgmac: write mac address to hardware in
ndo_set_mac_address")

Sounds OK, would it make sense to Cc stable?
Sure, I'll add Sergei's mods and do a v2 with stable on the Cc list
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help