Re: [PATCH 1/1] rds: ib: add the static type to the variables
From: Yuval Shaia <hidden>
Date: 2017-02-28 08:01:00
Also in:
linux-rdma
On Tue, Feb 28, 2017 at 01:45:40AM -0500, Zhu Yanjun wrote:
quoted hunk ↗ jump to hunk
The variables rds_ib_mr_1m_pool_size and rds_ib_mr_8k_pool_size are used only in the ib.c file. As such, the static type is added to limit them in this file. Cc: Joe Jin <redacted> Cc: Junxiao Bi <redacted> Signed-off-by: Zhu Yanjun <redacted> --- net/rds/ib.c | 4 ++-- net/rds/ib_mr.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-)diff --git a/net/rds/ib.c b/net/rds/ib.c index 8d70884..ecff01b 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c@@ -45,8 +45,8 @@ #include "ib.h" #include "ib_mr.h" -unsigned int rds_ib_mr_1m_pool_size = RDS_MR_1M_POOL_SIZE; -unsigned int rds_ib_mr_8k_pool_size = RDS_MR_8K_POOL_SIZE; +static unsigned int rds_ib_mr_1m_pool_size = RDS_MR_1M_POOL_SIZE; +static unsigned int rds_ib_mr_8k_pool_size = RDS_MR_8K_POOL_SIZE; unsigned int rds_ib_retry_count = RDS_IB_DEFAULT_RETRY_COUNT; module_param(rds_ib_mr_1m_pool_size, int, 0444);diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h index 24c086d..5d6e98a 100644 --- a/net/rds/ib_mr.h +++ b/net/rds/ib_mr.h@@ -107,8 +107,6 @@ struct rds_ib_mr_pool { }; extern struct workqueue_struct *rds_ib_mr_wq; -extern unsigned int rds_ib_mr_1m_pool_size; -extern unsigned int rds_ib_mr_8k_pool_size; extern bool prefer_frmr;
Reviewed-by: Yuval Shaia <redacted>
struct rds_ib_mr_pool *rds_ib_create_mr_pool(struct rds_ib_device *rds_dev, -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html