Thread (34 messages) 34 messages, 7 authors, 2017-03-02

Re: [PATCH net] net/mlx4_en: reception NAPI/IRQ race breaker

From: Eric Dumazet <hidden>
Date: 2017-02-26 17:40:39

On Sun, 2017-02-26 at 09:34 -0800, Eric Dumazet wrote:
I do not believe this bug is mlx4 specific.

Anything doing the following while hard irq were not masked :

local_bh_disable();
napi_reschedule(&priv->rx_cq[ring]->napi);
local_bh_enable();

Like in mlx4_en_recover_from_oom()

Can trigger the issue really.

Unfortunately I do not see how core layer can handle this.
Only the driver hard irq could possibly know that it could not grab
NAPI_STATE_SCHED
Actually we could use an additional bit for that, that the driver would
set even if NAPI_STATE_SCHED could not be grabbed.

Let me try something.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help