Re: [PATCH net 3/6] net/mlx5e: Do not reduce LRO WQE size when not using build_skb

On Wed, Feb 22, 2017 at 9:45 PM, Alexei Starovoitov
[off-list ref] wrote:

On Wed, Feb 22, 2017 at 7:20 AM, Saeed Mahameed [off-list ref] wrote:

quoted

From: Tariq Toukan <redacted>

When rq_type is Striding RQ, no room of SKB_RESERVE is needed
as SKB allocation is not done via build_skb.

Fixes: e4b85508072b ("net/mlx5e: Slightly reduce hardware LRO size")
Signed-off-by: Tariq Toukan <redacted>
Signed-off-by: Saeed Mahameed <redacted>

why this one is a bug fix?
Sound like an optimization from commit log.

It is a regression since  ("net/mlx5e: Slightly reduce hardware LRO size").
And we see due to this a small drop in HW LRO performance.
We just fixed the LRO size to be the same as it was before the
offending patch for striding RQ case.