Re: [patch net-next RFC 1/2] flow_dissecror: Move ARP dissection into a separate function

On Tue, Feb 21, 2017 at 01:32:35PM -0500, David Miller wrote:

From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 21 Feb 2017 15:33:18 +0100

quoted

From: Jiri Pirko <redacted>

Make the main flow_dissect function a bit smaller and move the ARP
dissection into a separate function. Along with that, do the ARP header
processing only in case the flow dissection user requires it.

Signed-off-by: Jiri Pirko <redacted>

These two changes look fine to me, although I hope that the compiler
doesn't decide to inline it anyways.

I think the approach taken would be a win regardless of inlining as
more logic is protected by dissector_uses_key() and thus less likely
to cause collateral damage.