Thread (3 messages) 3 messages, 2 authors, 2017-02-21

Re: [PATCH net-next] tcp: Revert "tcp: tcp_probe: use spin_lock_bh()"

From: David Miller <davem@davemloft.net>
Date: 2017-02-21 18:26:49

From: Eric Dumazet <redacted>
Date: Tue, 21 Feb 2017 06:21:47 -0800
This reverts commit e70ac171658679ecf6bea4bbd9e9325cd6079d2b.

jtcp_rcv_established() is in fact called with hard irq being disabled.

Initial bug report from Ricardo Nabinger Sanchez [1] still needs
to be investigated, but does not look like a TCP bug.

[1] https://www.spinics.net/lists/netdev/msg420960.html

Signed-off-by: Eric Dumazet <redacted>
Reported-by: kernel test robot <redacted>
Cc: Ricardo Nabinger Sanchez <redacted>
Applied.

But your analysis was quite sound, we can now invoke TCP input path
from user context, therefore this jprobe needs to use BH locking.  What
is the problem.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help