Re: [PATCH net-next v2 1/3] net: stmicro: prepare dwmac4 core for mtl

Hi David,

Às 6:02 PM de 2/17/2017, David Miller escreveu:

From: Joao Pinto <redacted>
Date: Thu, 16 Feb 2017 11:19:39 +0000

quoted

This patch adds the following features:

a) RX and TX scheduling algorithm configuration (can be configured in the
Device Tree)
b) TX VLAN tag priority configuration (can be configured in the Device Tree)
c) RX VLAN tag priority routing configuration (can be configured in the
Device Tree)
d) TX weight configuration (can be configured in the Device Tree)
e) RX queue to RX DMA channel mapping
f) RX queue enabling
g) MAC and individual queue related interrupt analysis
h) Flow Control configuration by queue

The number of RX and TX queues to use comes from the FEATURES register.

With this patch we get the core related operations ready for multiple
queue/channel.

Signed-off-by: Joao Pinto <redacted>

This would be so much easier to review if you used one patch for each
of those new configuration features.

In fact, it would make an appropriate complete patch series on it's own.

Should I put the multiple queues / channels changes in a single patch or should
I break it into a feature change / patch? What would be easier for you to review?

Thanks.

Thanks.