Thread (2 messages) flat view 2 messages, 2 authors, 2017-02-14

Re: [PATCH net V2] net/mlx5e: Disable preemption when doing TC statistics upcall

From: David Miller <davem@davemloft.net>
Date: 2017-02-14 16:56:59

From: Or Gerlitz <redacted>
Date: Sun, 12 Feb 2017 11:21:31 +0200
When called by HW offloading drivers, the TC action (e.g
net/sched/act_mirred.c) code uses this_cpu logic, e.g

 _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets)

per the kernel documention, preemption should be disabled, add that.

Before the fix, when running with CONFIG_PREEMPT set, we get a

BUG: using smp_processor_id() in preemptible [00000000] code: tc/3793

asserion from the TC action (mirred) stats_update callback.

Fixes: aad7e08d39bd ('net/mlx5e: Hardware offloaded flower filter statistics support')
Signed-off-by: Or Gerlitz <redacted>
Applied and queued up for -stable, thanks Or.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help