Re: [PATCH v2 net-next 5/9] openvswitch: Refactor labels initialization.

On Feb 8, 2017, at 3:06 PM, Joe Stringer [off-list ref] wrote:

On 8 February 2017 at 11:32, Jarno Rajahalme [off-list ref] wrote:

quoted

Refactoring conntrack labels initialization makes chenges in later

*changes

quoted

patches easier to review.

Signed-off-by: Jarno Rajahalme <redacted>

Minor other nit:

quoted

       cl = nf_ct_labels_find(ct);
       if (!cl) {
               nf_ct_labels_ext_add(ct);
               cl = nf_ct_labels_find(ct);
       }
+
+       return cl;
+}
+
+/* Initialize labels for a new, to be committed conntrack entry.  Note that

Maybe insert 'yet':

Initialize labels for a new, yet to be committed conntrack entry.  Note that

Fixed these typos for v4.

  Jarno