Re: [PATCH net 1/1] net: sock: Use double send/recv buff value to compare with max value

On Thu, Feb 9, 2017 at 12:00 AM, Eric Dumazet [off-list ref] wrote:

On Wed, 2017-02-08 at 21:07 +0800, fgao@ikuai8.com wrote:

quoted

From: Gao Feng <redacted>

Because the value of SO_SNDBUF and SO_RCVBUF is doubled before
assignment, so the real value of send and recv buffer could be more
than the max sysctl config sysctl_wmem_max and sysctl_rmem_max.

Now use doulbe send/recv buffer value to compare with sysctl_wmem_max
and sysctl_rmem_max, and it keeps consistence with SOCK_MIN_SNDBUF
and SOCK_MIN_RCVBUF.

Signed-off-by: Gao Feng <redacted>
---

Looks completely bogus, based on your comprehension of this code.

It is a config param, user could config any value.
So why give it one bogus?
If need more, user could config it by himself.

If you need to, fix the doc, not this code.

The current codes mean the buffer could exceed the sysctl max value.
It seems inconsistent.

Regards
Feng

Unless you give more details of course, why we should take your patch.