Re: [patch net-next 16/19] lib: Introduce priority array area manager

Thu, Feb 02, 2017 at 11:51:10PM CET, joe@perches.com wrote:

On Thu, 2017-02-02 at 16:12 +0100, Jiri Pirko wrote:

quoted

From: Jiri Pirko <redacted>

This introduces a infrastructure for management of linear priority
areas. Priority order in an array matters, however order of items inside
a priority group does not matter.

As an initial implementation, L-sort algorithm is used. It is quite
trivial. More advanced algorithm called P-sort will be introduced as a
follow-up. The infrastructure is prepared for other algos.

Alongside this, a testing module is introduced as well.

Signed-off-by: Jiri Pirko <redacted>
---
 MAINTAINERS            |   8 +
 include/linux/parman.h |  76 ++++++++++

[]

quoted

diff --git a/MAINTAINERS b/MAINTAINERS

[]

quoted

@@ -9375,6 +9375,14 @@ F:	drivers/video/fbdev/sti*
 F:	drivers/video/console/sti*
 F:	drivers/video/logo/logo_parisc*
 
+PARMAN

This is not particularly descriptive.
Perhaps expand the section header a little like:

PARMAN - Linear priority array areas manager

Okay

quoted

diff --git a/include/linux/parman.h b/include/linux/parman.h

[]

quoted

@@ -0,0 +1,76 @@
+/*
+ * include/linux/parman.h - Manager for linear priority array areas

[]

quoted

diff --git a/lib/Kconfig b/lib/Kconfig

[]

quoted

@@ -550,4 +550,7 @@ config STACKDEPOT
 config SBITMAP
 	bool
 
+config PARMAN
+	tristate "parman"

help section?  Why should this be selected?

I did not put help on purpose, as for other libs. User should not never
need to select this directly because as standalone, it has no sense to
have it enabled. This is always selected by users - only mlxsw for now.