Thread (14 messages) flat view 14 messages, 3 authors, 2017-01-26

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

From: Thomas Falcon <hidden>
Date: 2017-01-26 19:05:53
Also in: linuxppc-dev

On 01/26/2017 12:28 PM, Stephen Hemminger wrote:
On Wed, 25 Jan 2017 15:02:19 -0600
Thomas Falcon [off-list ref] wrote:
quoted
 static irqreturn_t ibmvnic_interrupt(int irq, void *instance)
 {
 	struct ibmvnic_adapter *adapter = instance;
+	unsigned long flags;
+
+	spin_lock_irqsave(&adapter->crq.lock, flags);
+	vio_disable_interrupts(adapter->vdev);
+	tasklet_schedule(&adapter->tasklet);
+	spin_unlock_irqrestore(&adapter->crq.lock, flags);
+	return IRQ_HANDLED;
+}
+
Why not use NAPI? rather than a tasklet
This interrupt function doesn't process packets, but message passing between firmware and driver for determining device capabilities and available resources, such as the number TX and RX queues. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help