Re: [PATCH/RFC v3 net] ravb: unmap descriptors when freeing rings

On Wed, Jan 25, 2017 at 07:18:15PM +0300, Sergei Shtylyov wrote:

On 01/24/2017 09:21 PM, Simon Horman wrote:

quoted

From: Kazuya Mizuguchi <redacted>

"swiotlb buffer is full" errors occur after repeated initialisation of a
device - f.e. suspend/resume or ip link set up/down. This is because memory
mapped using dma_map_single() in ravb_ring_format() and ravb_start_xmit()
is not released.  Resolve this problem by unmapping descriptors when
freeing rings.

   Could you look into the sh_eth driver which seems to have the same issue?

Sure, I will check.

quoted

Note, ravb_tx_free() is moved but not otherwise modified by this patch.

   This is not true anymore BTW.

Thanks for noticing, I'll fix that.

quoted

Signed-off-by: Kazuya Mizuguchi <redacted>
[simon: reworked]
Signed-off-by: Simon Horman <redacted>

MBR, Sergei