Re: [PATCH V3 net-next 02/14] net/ena: fix error handling when probe fails

Hi,

You are right. I'll remove this patch.

Regards,

Netanel

On 01/28/2017 01:33 AM, Lino Sanfilippo wrote:

Hi,

On 26.01.2017 23:18, Netanel Belgazal wrote:

quoted

When driver fails in probe, it will release all resources,
including adapter.
In case of probe failure, ena_remove should not try to
free the adapter resources.

Signed-off-by: Netanel Belgazal <redacted>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 

b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 7493ea3..cb60567 100644

--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c

@@ -3046,6 +3046,7 @@ static int ena_probe(struct pci_dev *pdev, 

const struct pci_device_id *ent)
 err_free_region:
     ena_release_bars(ena_dev, pdev);
 err_free_ena_dev:
+    pci_set_drvdata(pdev, NULL);
     vfree(ena_dev);
 err_disable_device:
     pci_disable_device(pdev);

Is this change really a "fix"? remove() should only be called if
probe() has been successful before, otherwise not. Did you experience
something different?

Regards,
Lino