Re: [PATCH] r8152: Allocate interrupt buffer as part of struct r8152
From: Eric Dumazet <hidden>
Date: 2017-01-31 19:54:39
Also in:
lkml
On Tue, 2017-01-31 at 11:06 -0800, Guenter Roeck wrote:
When unloading the r8152 driver using the 'unbind' sysfs attribute in a system with KASAN enabled, the following error message is seen on a regular basis.
quoted hunk ↗ jump to hunk
static int alloc_all_mem(struct r8152 *tp)@@ -1423,10 +1420,6 @@ static int alloc_all_mem(struct r8152 *tp) if (!tp->intr_urb) goto err1; - tp->intr_buff = kmalloc(INTBUFSIZE, GFP_KERNEL); - if (!tp->intr_buff) - goto err1; - tp->intr_interval = (int)ep_intr->desc.bInterval; usb_fill_int_urb(tp->intr_urb, tp->udev, usb_rcvintpipe(tp->udev, 3), tp->intr_buff, INTBUFSIZE, intr_callback,
This might lead to intr_buff being backed by vzalloc() instead of kzalloc() (check alloc_netdev_mqs()) It looks like it could cause a bug. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html