Thread (3 messages) flat view 3 messages, 3 authors, 2017-01-30

RE: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page

From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: 2017-01-30 09:00:15
Also in: lkml

-----Original Message-----
From: Arseny Solokha [mailto:asolokha@kb.kras.ru]
Sent: Sunday, January 29, 2017 2:52 PM
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Arseny Solokha
[off-list ref]
Subject: [PATCH] gianfar: synchronize DMA API usage by free_skb_rx_queue w/
gfar_new_page

From: Arseny Solokha <redacted>

In spite of switching to paged allocation of Rx buffers, the driver still
called dma_unmap_single() in the Rx queues tear-down path.
Except for the dma-debug part generating the warning, the implementation of 
dma_unmap_single() looks identical to dma_unmap_page(), both wrappers calling 
ops->unmap_page() with same params.
But for consistency, dma_unmap_page() seems the better choice indeed.
Thanks.

Acked-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help