Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
From: Joe Perches <joe@perches.com>
Date: 2017-01-27 19:48:47
Also in:
linux-wireless, lkml
On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
This fixes the checkpatch.pl warnings: * Macros should not use a trailing semicolon. * Spaces required around that '='. * Symbolic permissions 'S_IRUGO' are not preferred.
OK
* Macro argument reuse 'buflen' - possible side-effects
Not all checkpatch messages need fixing. This is one of them.
quoted hunk ↗ jump to hunk
diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c
[]
quoted hunk ↗ jump to hunk
@@ -17,11 +17,12 @@ static ssize_t name## _read(struct file *file, char __user *userbuf, \ size_t count, loff_t *ppos) \ { \ - struct wiphy *wiphy= file->private_data; \ - char buf[buflen]; \ + struct wiphy *wiphy = file->private_data; \ + int __buflen = __builtin_constant_p(buflen) ? buflen : -1; \ + char buf[__buflen]; \
That's rather an odd change too