RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
From: Rafal Ozieblo <hidden>
Date: 2017-01-26 15:16:04
Also in:
linux-arm-kernel, lkml
-----Original Message-----
From: Andrei Pistirica [mailto:andrei.pistirica@microchip.com]
Sent: 19 stycznia 2017 16:56
Subject: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM
+static inline bool gem_has_ptp(struct macb *bp)
+{
+ return !!(bp->caps & MACB_CAPS_GEM_HAS_PTP);
+}Why don't you use hardware capabilities here? Would it be better to read it from hardware instead adding it to many configuration?